[PATCH] drm/nv50-: make dma-objects read-only where appropriate
Ben Skeggs
skeggsb at gmail.com
Tue Sep 3 20:23:37 PDT 2013
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst
<maarten.lankhorst at canonical.com> wrote:
> I don't see why the display engine would need write access to the entirety of
> vram, when read-only access is enough.
Meh, this really doesn't matter... We're doing the same setup as
nvidia do here, and I see no good reason not to.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>
> ---
> drivers/gpu/drm/nouveau/nv50_display.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
> index aab72f5..eac6b2a 100644
> --- a/drivers/gpu/drm/nouveau/nv50_display.c
> +++ b/drivers/gpu/drm/nouveau/nv50_display.c
> @@ -159,7 +159,7 @@ nv50_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NV50_DMA_CONF0_ENABLE |
> @@ -172,7 +172,7 @@ nv50_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NV50_DMA_CONF0_ENABLE | 0x70 |
> @@ -185,7 +185,7 @@ nv50_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NV50_DMA_CONF0_ENABLE | 0x7a |
> @@ -204,7 +204,7 @@ nvc0_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NVC0_DMA_CONF0_ENABLE,
> @@ -216,7 +216,7 @@ nvc0_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NVC0_DMA_CONF0_ENABLE | 0xfe,
> @@ -228,7 +228,7 @@ nvc0_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NVC0_DMA_CONF0_ENABLE | 0xfe,
> @@ -246,7 +246,7 @@ nvd0_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NVD0_DMA_CONF0_ENABLE |
> @@ -259,7 +259,7 @@ nvd0_dmac_create_fbdma(struct nouveau_object *core, u32 parent)
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> .conf0 = NVD0_DMA_CONF0_ENABLE | 0xfe |
> @@ -316,7 +316,7 @@ nv50_dmac_create(struct nouveau_object *core, u32 bclass, u8 head,
> NV_DMA_IN_MEMORY_CLASS,
> &(struct nv_dma_class) {
> .flags = NV_DMA_TARGET_VRAM |
> - NV_DMA_ACCESS_RDWR,
> + NV_DMA_ACCESS_RD,
> .start = 0,
> .limit = pfb->ram->size - 1,
> }, sizeof(struct nv_dma_class), &object);
> --
> 1.8.3.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
More information about the dri-devel
mailing list