[PATCH] drm/omap: fix error return code in omap_dmm_probe()

Rob Clark robdclark at gmail.com
Wed Sep 11 04:26:47 PDT 2013


On Wed, Sep 11, 2013 at 7:16 AM, Wei Yongjun <weiyj.lk at gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> Fix to return -ENOMEM in the refill memory alloc error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

Thanks

Reviewed-by: Rob Clark <robdclark at gmail.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 9b794c9..ab546c9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -675,6 +675,7 @@ static int omap_dmm_probe(struct platform_device *dev)
>                                 &omap_dmm->refill_pa, GFP_KERNEL);
>         if (!omap_dmm->refill_va) {
>                 dev_err(&dev->dev, "could not allocate refill memory\n");
> +               ret = -ENOMEM;
>                 goto fail;
>         }
>
>


More information about the dri-devel mailing list