[PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Sep 20 07:12:44 PDT 2013
On Fri, Sep 20, 2013 at 02:21:37AM +0100, Ben Hutchings wrote:
> On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote:
> > -dma_set_coherent_mask() will always be able to set the same or a
> > -smaller mask as dma_set_mask(). However for the rare case that a
> > +The coherent coherent mask will always be able to set the same or a
> > +smaller mask as the streaming mask. However for the rare case that a
> The new wording doesn't make sense; a mask doesn't set itself. I would
> "The coherent mask can always be set to the same or a smaller mask than
> the streaming mask."
Yes, the original sentence is not particularly good, but I think even
your modified version can be interpreted as "a mask setting itself"
for all the same reasons that the original can be (which mask does "same"
Even so, I prefer your version. Thanks. :)
More information about the dri-devel