[PATCHv4 06/13] drm: Add primary plane helpers (v2)

[Laurent Pinchart]

Hi Daniel,

On Friday 28 March 2014 18:54:49 Daniel Vetter wrote:
> On Fri, Mar 28, 2014 at 04:48:42PM +0100, Laurent Pinchart wrote:
> > On Friday 28 March 2014 09:32:06 Daniel Vetter wrote:
> > > On Thu, Mar 27, 2014 at 05:44:31PM -0700, Matt Roper wrote:
> > > > When we expose non-overlay planes to userspace, they will become
> > > > accessible via standard userspace plane API's.  We should be able to
> > > > handle the standard plane operations against primary planes in a
> > > > generic way via the modeset handler.
> > > > 
> > > > Drivers that can program primary planes more efficiently, that want to
> > > > use their own primary plane structure to track additional information,
> > > > or that don't have the limitations assumed by the helpers are free to
> > > > provide their own implementation of some or all of these handlers.
> > > > 
> > > > v2:
> > > >  - Move plane helpers to a new file (drm_plane_helper.c)
> > > >  - Tighten checks on update handler (check for scaling, CRTC coverage,
> > > >    subpixel positioning)
> > > >  - Pass proper panning parameters to modeset interface
> > > >  - Disallow disabling primary plane (and thus CRTC) if other planes
> > > >    are still active on the CRTC.
> > > >  - Use a minimal format list that should work on all hardware/drivers.
> > > >    Drivers may call this function with a more accurate plane list to
> > > >    enable additional formats they can support.
> > > > 
> > > > Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> > > > ---
> > > > 
> > > >  drivers/gpu/drm/Makefile           |   3 +-
> > > >  drivers/gpu/drm/drm_plane_helper.c | 312 ++++++++++++++++++++++++++++
> > > >  include/drm/drm_plane_helper.h     |  49 ++++++
> > > 
> > > DocBook integration is missing for all the great kerneldoc you've
> > > written.
> > 
> > I'd go a bit further than that, there's a chapter on planes in the DocBook
> > documentation that should also be updated, otherwise it would get
> > outdated.
> 
> Probably better done as part of the patch which actually adds primary
> planes, since this here is just the convenience helpers for easier
> transition ...

Sure, that's perfectly fine with me.

> > > That boils down to adding a new section next to the other helper
> > > libraries in the drm docbook to pull the kerneldoc in and running make
> > > htmldocs to make sure the kerneldoc checks out.
> > > 
> > > If you want you can add a DOC: overview section and pull that into the
> > > docbook too, see e.g. how the drm prime helpers are integrated.
> > > 
> > > >  3 files changed, 363 insertions(+), 1 deletion(-)
> > > >  create mode 100644 drivers/gpu/drm/drm_plane_helper.c
> > > >  create mode 100644 include/drm/drm_plane_helper.h

-- 
Regards,

Laurent Pinchart