[PATCH] drm: fix memory leak in msm_gem when no iommu is present

Rob Clark robdclark at gmail.com
Mon Apr 14 12:41:23 PDT 2014


fyi, I have this patch applied locally (well, actually the previous
one with slightly amended subject line).. was just waiting a bit to
see if any other fixes turned up before sending a fixes pull.  Thanks!

BR,
-R

On Mon, Apr 14, 2014 at 2:40 PM, Micah Richert
<richert at braincorporation.com> wrote:
> Signed-off-by: Micah Richert <richert at braincorporation.com>
> ---
>  drivers/gpu/drm/msm/msm_gem.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index e8458bc..c818a06 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -118,8 +118,10 @@ static void put_pages(struct drm_gem_object *obj)
>
>                 if (iommu_present(&platform_bus_type))
>                         drm_gem_put_pages(obj, msm_obj->pages, true, false);
> -               else
> +               else {
>                         drm_mm_remove_node(msm_obj->vram_node);
> +                       drm_free_large(msm_obj->pages);
> +               }
>
>                 msm_obj->pages = NULL;
>         }
> --
> 1.8.3.2
>


More information about the dri-devel mailing list