[PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

Thierry Reding thierry.reding at gmail.com
Wed Apr 16 12:49:46 PDT 2014


On Fri, Apr 11, 2014 at 09:48:00AM -0600, Stephen Warren wrote:
> On 04/11/2014 02:36 AM, Duan Jiong wrote:
> > This patch fixes coccinelle error regarding usage of IS_ERR and
> > PTR_ERR instead of PTR_ERR_OR_ZERO.
> 
> Same comment as the other patch; I prefer the existing code (although
> I'll defer to Thierry as maintainer of both these pieces of code).

I feel the same way. And in fact I believe we already rejected a similar
a while back for the same reason.

> It would help if the commit description quoted the coccinelle error.

"Suggestion" would probably be more accurate. There is no error here.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140416/3701191c/attachment.sig>


More information about the dri-devel mailing list