[PATCHv3 1/5] drm: exynos: hdmi: remove usage of struct s5p_hdmi_platform_data
Tomasz Stanislawski
t.stanislaws at samsung.com
Thu Apr 17 00:26:02 PDT 2014
Hi Joonyoung,
On 04/17/2014 03:54 AM, Joonyoung Shim wrote:
> Hi Tomasz,
>
> On 04/17/2014 12:12 AM, Tomasz Stanislawski wrote:
>> This patch continues shift of DRM EXYNOS to DT-only configuration.
>> The usage of the old structure for HDMI's platform data is
>> removed.
>>
>> Signed-off-by: Tomasz Stanislawski <t.stanislaws at samsung.com>
[snip]
>> + ret = drm_hdmi_dt_parse(hdata, dev->of_node);
>> + if (ret)
>> + return -EINVAL;
>
> It's better to return ret value.
>
I was considering return ret value. However, I preferred to
be consistent with other 'returns' which returns error literals.
Anyway, I will change it to 'return ret'.
Regards,
Tomasz Stanislawski
More information about the dri-devel
mailing list