[PATCH 0/3] drm/tegra: Use standard suffix for hotplug detect GPIO property
Lucas Stach
dev at lynxeye.de
Thu Apr 17 10:25:54 PDT 2014
Am Donnerstag, den 17.04.2014, 14:02 +0200 schrieb Thierry Reding:
> From: Thierry Reding <treding at nvidia.com>
>
> The hotplug detect GPIO in the current bindings use "-gpio" as suffix,
> whereas the standard suffix is the plural: "-gpios". This small series
> replaces this in three steps to preserve bisectability:
>
> - Patch 1 adds new nvidia,hpd-gpios properties to existing device tree
> files while marking existing nvidia,hpd-gpio ones as deprecated.
> - Patch 2 makes use of the new property name in the driver and updates
> the device tree bindings.
> - Patch 3 removes the deprecated properties from device tree files.
>
> Since this touches both DRM and Tegra trees, I've prepared a stable
> branch[0] that can be pulled into both trees to make the transition
> easier.
>
What's the real benefit to this series? After all you are breaking
existing devicetrees here, as the driver doesn't continue to recognize
the old name. IMHO adding a missed 's' to the property name isn't enough
reason to do this.
Regards,
Lucas
More information about the dri-devel
mailing list