[PATCH] drm/fb-helper: Fix hpd vs. initial config races

Daniel Vetter daniel at ffwll.ch
Tue Apr 22 04:46:09 PDT 2014


On Tue, Apr 22, 2014 at 12:08 PM, Thierry Reding
<thierry.reding at gmail.com> wrote:
> void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper,
>                            const struct drm_fb_helper_funcs *funcs)
> {
>         helper->funcs = funcs;
>         helper->dev = dev;
> }
>
> So I wonder if that's still what we want or whether drivers should
> simply be doing that manually if they need to. Having a function for it
> gives us a place to document things, though, and perhaps at some point
> we'll have to extend this, so it may be a good idea after all, even if
> it's just the two lines currently.

Yeah the usefulness of this will be in the documentation that explains
how to use it, not in the code sharing/extraction. For critical code
we could just plunk it into a static inline, but since this is init
code I wouldn't really care with that.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list