[PATCH] drm/exynos: use %pad for dma_addr_t

Daniel Kurtz djkurtz at chromium.org
Tue Apr 22 09:37:41 PDT 2014


On Tue, Apr 22, 2014 at 1:45 PM, Jingoo Han <jg1.han at samsung.com> wrote:

> Use %pad for dma_addr_t, because a dma_addr_t type can vary
> based on build options. So, it prevents possible build warnings
> in printks.
>
> Signed-off-by: Jingoo Han <jg1.han at samsung.com>
>

Yay!

Reviewed-by: Daniel Kurtz <djkurtz at chromium.org>


> ---
>  drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |    2 +-
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c
> b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c
> index 59827cc..9cf71fa 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c
> @@ -263,7 +263,7 @@ struct drm_gem_object
> *exynos_dmabuf_prime_import(struct drm_device *drm_dev,
>         buffer->sgt = sgt;
>         exynos_gem_obj->base.import_attach = attach;
>
> -       DRM_DEBUG_PRIME("dma_addr = 0x%x, size = 0x%lx\n",
> buffer->dma_addr,
> +       DRM_DEBUG_PRIME("dma_addr = %pad, size = 0x%lx\n",
> &buffer->dma_addr,
>
> buffer->size);
>
>         return &exynos_gem_obj->base;
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> index 3319289..e4689ef 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> @@ -221,7 +221,7 @@ static void vidi_win_commit(struct exynos_drm_manager
> *mgr, int zpos)
>
>         win_data->enabled = true;
>
> -       DRM_DEBUG_KMS("dma_addr = 0x%x\n", win_data->dma_addr);
> +       DRM_DEBUG_KMS("dma_addr = %pad\n", &win_data->dma_addr);
>
>         if (ctx->vblank_on)
>                 schedule_work(&ctx->work);
> --
> 1.7.10.4
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140423/530db239/attachment.html>


More information about the dri-devel mailing list