[PATCH 09/19] drm/radeon: handle lockup in delayed work, v2
maarten.lankhorst at canonical.com
Mon Aug 4 07:40:24 PDT 2014
op 04-08-14 16:37, Christian König schreef:
>> It'a pain to deal with gpu reset.
> Yeah, well that's nothing new.
>> I've now tried other solutions but that would mean reverting to the old style during gpu lockup recovery, and only running the delayed work when !lockup.
>> But this meant that the timeout was useless to add. I think the cleanest is keeping the v2 patch, because potentially any waiting code can be called during lockup recovery.
> The lockup code itself should never call any waiting code and V2 doesn't seem to handle a couple of cases correctly either.
> How about moving the fence waiting out of the reset code?
What cases did I miss then?
I'm curious how you want to move the fence waiting out of reset, when there are so many places that could potentially wait, like radeon_ib_get can call radeon_sa_bo_new which can do a wait, or radeon_ring_alloc that can wait on radeon_fence_wait_next, etc.
More information about the dri-devel