[PATCH 1/6] drm: Renaming DP training vswing/pre-emph defines
Jingoo Han
jg1.han at samsung.com
Tue Aug 5 19:01:15 PDT 2014
On Tuesday, August 05, 2014 8:08 PM, Sonika Jindal wrote:
>
> From: Sonika Jindal <sonika.jindal at intel.com>
>
> Renaming defines to have levels instead of nominal values.
(+cc Daniel Vetter)
Hi Sonika Jindal,
Thank you for sending the patch. However, please add the reason
to this commit message, as you said at '[PATCH 0/6] Rename DP
training vswing/pre-emph defines'.
Best regards.
Jingoo Han
>
> Signed-off-by: Sonika Jindal <sonika.jindal at intel.com>
> ---
> include/drm/drm_dp_helper.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index a21568b..70f362b 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -190,16 +190,16 @@
> # define DP_TRAIN_VOLTAGE_SWING_MASK 0x3
> # define DP_TRAIN_VOLTAGE_SWING_SHIFT 0
> # define DP_TRAIN_MAX_SWING_REACHED (1 << 2)
> -# define DP_TRAIN_VOLTAGE_SWING_400 (0 << 0)
> -# define DP_TRAIN_VOLTAGE_SWING_600 (1 << 0)
> -# define DP_TRAIN_VOLTAGE_SWING_800 (2 << 0)
> -# define DP_TRAIN_VOLTAGE_SWING_1200 (3 << 0)
> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_0 (0 << 0)
> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_1 (1 << 0)
> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_2 (2 << 0)
> +# define DP_TRAIN_VOLTAGE_SWING_LEVEL_3 (3 << 0)
>
> # define DP_TRAIN_PRE_EMPHASIS_MASK (3 << 3)
> -# define DP_TRAIN_PRE_EMPHASIS_0 (0 << 3)
> -# define DP_TRAIN_PRE_EMPHASIS_3_5 (1 << 3)
> -# define DP_TRAIN_PRE_EMPHASIS_6 (2 << 3)
> -# define DP_TRAIN_PRE_EMPHASIS_9_5 (3 << 3)
> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_0 (0 << 3)
> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_1 (1 << 3)
> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_2 (2 << 3)
> +# define DP_TRAIN_PRE_EMPHASIS_LEVEL_3 (3 << 3)
>
> # define DP_TRAIN_PRE_EMPHASIS_SHIFT 3
> # define DP_TRAIN_MAX_PRE_EMPHASIS_REACHED (1 << 5)
> --
> 1.7.10.4
More information about the dri-devel
mailing list