[PATCH] drm: Do not use BUG_ON(!spin_is_locked())
sanjeevsharmaengg at gmail.com
Mon Aug 11 05:02:26 PDT 2014
Here is the old discussion carried out on this.
On Mon, Aug 11, 2014 at 5:31 PM, sanjeev sharma <sanjeevsharmaengg at gmail.com
> Hello David,
> Do you see any problem in replacing with assert_spin_locked() and here is
> old discusion around the
> On Mon, Aug 11, 2014 at 5:15 PM, David Rientjes <rientjes at google.com>
>> On Sun, 10 Aug 2014, Guenter Roeck wrote:
>> > spin_is_locked() always returns false in uniprocessor configurations
>> > and can therefore not be used with BUG_ON. Replace it with
>> > assert_spin_locked(), which exists for that very purpose.
>> It may be helpful to assess whether any of these sites should be converted
>> to lockdep_assert_held() so they have no cost when lockdep isn't enabled
>> but still reveal problems when debugging.
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the dri-devel