[PATCH v2] imx-drm: imx-drm-core: add suspend/resume support

Greg KH greg at kroah.com
Tue Aug 19 02:16:41 PDT 2014

On Tue, Aug 19, 2014 at 09:08:08AM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 18, 2014 at 02:25:34PM +0800, Shawn Guo wrote:
> > On Fri, Jul 25, 2014 at 02:20:40PM +0800, Shawn Guo wrote:
> > > HDMI currently stops working after a system suspend/resume cycle.  The
> > > cause is that the mode setting states in hardware gets lost and isn't
> > > restored across the suspend/resume cycle.
> > > 
> > > The patch adds a very basic suspend/resume support to imx-drm driver,
> > > and calls drm_helper_resume_force_mode() in .resume hook to restore the
> > > mode setting states, so that HDMI can continue working after a system
> > > suspend/resume cycle.
> > > 
> > > Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
> > 
> > Hi Russell,
> > 
> > What's your take on this patch?
> I've mostly stepped away from collecting imx-drm patches for Greg, and
> I'm probably going to be dropping those patches which I had queued up
> a while back for Greg.
> Greg wishes me to use signed tags for pull requests.  This is not how I
> work, and would mean having to rewrite a bunch of my scripts to cater
> for Greg's special case.  No one else requires this.

"special case"?  That's what Linus wants from everyone as well, how hard
is it to add a simple line to your scripts that does:
	git tag -u ${KEY} -s ${TREE} ${BRANCH}

before doing:
	git request-pull .... ${TREE}

It's just a simple one line addition, right?  What am I missing here?

> I haven't had the time to start looking at what this would require
> during the last three months, so the only other solution is to step
> down from dealing with imx-drm patches.

I never said I would refuse to take patches from you if you didn't do
this, I only asked if you could, as it makes me feel more comfortable
taking pull requests from you as you are the only one that doesn't do
this for trees I pull.

You should be using signed tags for your other trees as well, it's not
just me who should be asking you for this...


greg k-h

More information about the dri-devel mailing list