[PATCH] drm/exynos/fbdev: set smem_len for fbdev

Daniel Kurtz djkurtz at chromium.org
Sun Aug 24 07:50:57 PDT 2014

Commit [0] stopped setting fix.smem_start and fix.smem_len when creating
the fbdev.

[0] 2f1eab8d8ab59e799f7d51d62410b398607a7bc3
  drm/exynos/fbdev: don't set fix.smem/mmio_{start,len}

However, smem_len is used by some userland applications to calculate the
size for mmap.  In particular, it is used by xf86-video-fbdev:


So, let's restore setting the smem_len to unbreak things for these users.

Note: we are still leaving smem_start set to 0.

Reported-by: Siarhei Siamashka <siarhei.siamashka at gmail.com>
Reported-by: Günther Noack <me at guenthernoack.de>
Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
I am able to compile test this change, but would appreciate help testing it
on a system that uses xf86-video-fbdev.


 drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 5a7cd8b..f865736 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -125,6 +125,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
 	fbi->screen_base = buffer->kvaddr;
 	fbi->screen_size = size;
+	fbi->fix.smem_len = size;
 	return 0;

More information about the dri-devel mailing list