[PATCH v2] drm/ast: Improve mode matching

Egbert Eich eich at freedesktop.org
Wed Aug 27 05:28:26 PDT 2014


Hi YC,

you should probably be a bit more verbose in your changelog entry.

As subject something like:
     Add reduced blanking modes for wide screen mode

As text:
     Add reduced blanking modes, improve mode matching to
     identify these modes by their sync polarities.

Y.C. Chen writes:
 > From: "Y.C. Chen" <yc_chen at aspeedtech.com>
 > 
 > Signed-off-by: Egbert Eich <eich at suse.com>
 > Signed-off-by: Y.C. Chen <yc_chen at aspeedtech.com>
 > 
 > v2: Add two pass mode selection, first try to match sync polarities and refresh
 >     if this fails, try matching refresh only. Suggested by: Egbert Eich <eich at suse.com>
 > @@ -99,6 +104,8 @@ static struct ast_vbios_dclk_info dclk_table[] = {
 >  	{0x25, 0x65, 0x80},					/* 16: VCLK88.75    */
 >  	{0x77, 0x58, 0x80},					/* 17: VCLK119      */
 >  	{0x32, 0x67, 0x80},				    /* 18: VCLK85_5     */
 > +	{0x6a, 0x6d, 0x80},					/* 19: VCLK97_75	*/

Weren't you going to put this line into a separate patch 
- as it fixes a 'run off the end of the list' bug?

 > +	{0x3b, 0x2c, 0x81},					/* 1A: VCLK118_25	*/
 >  };
 >  
 >  static struct ast_vbios_stdtable vbios_stdtable[] = {
 > @@ -245,8 +252,10 @@ static struct ast_vbios_enhtable res_1360x768[] = {

I've tested your patches, so with the above changes:

Tested-by: Egbert Eich <eich at suse.com>

Cheers,
	Egbert.


More information about the dri-devel mailing list