drm: sti: add HDMI driver

Dan Carpenter dan.carpenter at oracle.com
Fri Aug 29 01:15:51 PDT 2014


Hello Benjamin Gaignard,

The patch 5402626c83a2: "drm: sti: add HDMI driver" from Jul 30,
2014, leads to the following static checker warning:

	drivers/gpu/drm/sti/sti_hdmi.c:301 hdmi_avi_infoframe_config()
	error: buffer overflow 'frame' 13 <= 13

drivers/gpu/drm/sti/sti_hdmi.c
   298          hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD2(HDMI_IFRAME_SLOT_AVI));
   299  
   300          val = frame[0xC];
   301          val |= frame[0xD] << 8;

frame[] only has 0xD elements so we are one element past the end here.

   302          hdmi_write(hdmi, val, HDMI_SW_DI_N_PKT_WORD3(HDMI_IFRAME_SLOT_AVI));
   303  

regards,
dan carpenter


More information about the dri-devel mailing list