[PATCHv2 0/8] Upstreaming the Android build and misc fixes
Emil Velikov
emil.l.velikov at gmail.com
Fri Aug 29 03:02:53 PDT 2014
Hi Tim,
On 29/08/14 10:44, Gore, Tim wrote:
> Hi Emil, sorry for the delay.
> I still see the same patch error for patch 3/8. The patch diff
> for intel/makefile.am has as part of its context:
>
> # Eric Anholt <eric at anholt.net>
>
> Whereas the source file has
>
> # Eric Anholt <eric at anholt.net>
>
> So the patch fails. Its trivial of course. Perhaps there is some automatic
> Substitution getting done by some tool.
The issue you're seeing here is (afaik) an anti-spam feature. The ML
software/parser automatically substitutes/obscures email addresses.
For any future case, I would recommend adding a remote branch rather than
picking patches from mailling-lists - not all of them play nice :\
> Maybe git-am will automatically
> Fix this, not sure, I don't have a workflow for git-am.
> My source comes from
> Git://anongit.freedesktop.org/git/mesa/drm
> Remote =origin
> Merge = refs/heads/master
>
> Other than that, as I say the patches look fine, and I have successfully built
> Libdrm in an Android tree using these patches and "mm".
> I am out of the office from 12:00 until Thurs 4th Sept now.
>
Nice. They build fine on my end as well. I've even had a couple of people test
them (with a mmap patch on top) alongside mesa 10.2 :)
I was hoping for an acked-by/reviewed-by, but it seems like I'll push the
series as is.
Thanks
Emil
> Tim
>
More information about the dri-devel
mailing list