[Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

Daniel Vetter daniel at ffwll.ch
Fri Aug 29 08:43:37 PDT 2014

On Fri, Aug 29, 2014 at 5:38 PM, Ville Syrjälä <
ville.syrjala at linux.intel.com> wrote:

> > Would grabbing
> > struct drm_plane_state from the atomic branch fix this for you?
> That looks like it's meant to house the user requested coordinates
> rather than the clipped ones. What you could do is just shovel the
> drm_rects we use during the clipping into a new i915 specific plane
> config struct and pass that to both check and commit. We can later
> look into moving that stuff into some core struct if seems like a win
> for more than one driver.

Creating a new intel_plane_config will also be better for merging, since if
you depend upon drm_plane_state directly your patch will be blocked. Ofc
that means we need to do a bit of refactoring once atomic has landed, but
that shouldn't be too onerous really.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/cf4451e0/attachment.html>

More information about the dri-devel mailing list