[PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support
Rob Clark
robdclark at gmail.com
Wed Dec 3 08:51:06 PST 2014
On Mon, Dec 1, 2014 at 4:56 PM, Jilai Wang <jilaiw at codeaurora.org> wrote:
> + /* Enable HDCP Encryption */
> + hdmi_write(hdmi, REG_HDMI_HDCP_CTRL, BIT(0) | BIT(8));
btw, as Bjron mentioned, there are a lot of these open coded BIT(n)..
but from a quick check, the first two or three I looked at, we already
have the appropriate defines in the rnndb generated headers, to
instead do:
/* Enable HDCP Encryption */
hdmi_write(hdmi, REG_HDMI_HDCP_CTRL,
HDMI_HDCP_CTRL_ENABLE |
HDMI_HDCP_CTRL_ENCRYPTION_ENABLE);
that seems somewhat more readable to me ;-)
BR,
-R
More information about the dri-devel
mailing list