[PATCH 3/6] drm/radeon: add command submission IDs

Michel Dänzer michel at daenzer.net
Tue Dec 9 01:01:39 PST 2014


On 09.12.2014 01:11, Christian König wrote:
> From: Christian König <christian.koenig at amd.com>
> 
> This patch adds a new 64bit ID as a result to each command submission.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>

I noticed a few spelling mistakes, see below.

Other than these minor nits, I haven't noticed any problems in this
series, though I haven't looked at it in too much detail.


> +/*
> + * ID sequences
> + * This code generates a 64bit identifier for a command submission.
> + * It works by adding the fence of the command submission to a automatically

'to an automatically'


> +/**
> + * radeon_seq_query - lockup fence by it's ID

'look up fence by its ID'

> + * @seq: sequence object
> + * @id: the generated ID
> + *
> + * Lockup the associated fence by it's ID.

'Look up the associated fence by its ID.'


> +/* The fourth and fives dword are a 64bit fence ID generated for this CS */

'fourth and fifth'


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the dri-devel mailing list