[PATCH 1/4] amdkfd: fix error printing in kfd_ioctl()

Christian König deathsimple at vodafone.de
Sun Dec 14 06:10:17 PST 2014


Am 14.12.2014 um 14:35 schrieb Oded Gabbay:
> When an ioctl function returns -EAGAIN, don't print error in kfd_ioctl()

You most likely want to handle -ERESTARTSYS the same way.

Christian.

>
> Signed-off-by: Oded Gabbay <oded.gabbay at amd.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 7d4974b..69c5fe7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -571,7 +571,7 @@ static long kfd_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
>   		break;
>   	}
>   
> -	if (err < 0)
> +	if ((err < 0) && (err != -EAGAIN))
>   		dev_err(kfd_device,
>   			"ioctl error %ld for ioctl cmd 0x%x (#%d)\n",
>   			err, cmd, _IOC_NR(cmd));



More information about the dri-devel mailing list