[PATCH 1/4] amdkfd: fix error printing in kfd_ioctl()

Daniel Vetter daniel at ffwll.ch
Sun Dec 14 23:59:13 PST 2014


On Sun, Dec 14, 2014 at 03:10:17PM +0100, Christian König wrote:
> Am 14.12.2014 um 14:35 schrieb Oded Gabbay:
> >When an ioctl function returns -EAGAIN, don't print error in kfd_ioctl()
> 
> You most likely want to handle -ERESTARTSYS the same way.

Please just reuse drmIoctl or at least copy it perfectly. We've had too
many tears about ioctl restarting going badly wrong. Also make sure you
never do a raw ioctl call anywhere for amdkfd. Adding Dave.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list