[PATCH] drm/i915: tame the chattermouth (v2)

[Daniel Vetter]

On Mon, Dec 15, 2014 at 10:22:49PM +0200, Jani Nikula wrote:
> On Mon, 15 Dec 2014, Rob Clark <robdclark at gmail.com> wrote:
> > Many distro's have mechanism in place to collect and automatically file
> > bugs for failed WARN()s.  And since i915 has a lot of hw state sanity
> > checks which result in WARN(), it generates quite a lot of noise which
> > is somewhat disconcerting to the end user.
> >
> > Separate out the internal hw-is-in-the-state-I-expected checks into
> > I915_STATE_WARN()s and allow configuration via i915.verbose_checks module
> > param about whether this will generate a full blown stacktrace or just
> > DRM_ERROR().  The new moduleparam defaults to true, so by default there
> > is no change in behavior.  And even when disabled, you will still get
> > an error message logged.
> >
> > v2: paint the macro names blue, clarify that the default behavior
> >     remains the same as before
> >
> > Signed-off-by: Rob Clark <robdclark at gmail.com>
> 
> FWIW this is
> 
> Acked-by: Jani Nikula <jani.nikula at intel.com>
> 
> even though I opposed v1. While I'm still not thrilled by an extra
> module param, my main concern was alleviated by Rob pointing out to me
> the default of that param leaves old behaviour unchanged.

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch