drm: rockchip: Add basic drm driver
Mark yao
mark.yao at rock-chips.com
Tue Dec 16 16:56:25 PST 2014
Hello Dan,
Thanks for your review, I will fix it soon.
Do you use a script to find out these issues? I was interested in this
script.
Can you teach me how to find this script and use it?
regards,
Mark Yao
On 2014年12月16日 19:51, Dan Carpenter wrote:
> Hello Mark Yao,
>
> The patch 2048e3286f34: "drm: rockchip: Add basic drm driver" from
> Aug 22, 2014, leads to the following static checker warning:
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1383 vop_bind()
> warn: unsigned 'vop->irq' is never less than zero.
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> 1381
> 1382 vop->irq = platform_get_irq(pdev, 0);
> 1383 if (vop->irq < 0) {
> ^^^^^^^^^^^^
> Doesn't work.
right, we should use "int" but not "unsigned int" for irq type.
> 1384 dev_err(dev, "cannot find irq for vop\n");
> 1385 return vop->irq;
> 1386 }
> 1387
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1188 vop_create_crtc()
> warn: missing error code here? 'of_get_child_by_name()' failed.
>
> 1184 port = of_get_child_by_name(dev->of_node, "port");
> 1185 if (!port) {
> 1186 DRM_ERROR("no port node found in %s\n",
> 1187 dev->of_node->full_name);
>
> Probably, "ret = -ENODEV;"
right, "ret = -ENODEV" is needed.
>
> 1188 goto err_cleanup_crtc;
> 1189 }
> 1190
>
>
> regards,
> dan carpenter
>
>
>
More information about the dri-devel
mailing list