drm/dsi: Add message to packet translator

Thierry Reding treding at nvidia.com
Wed Dec 17 02:58:06 PST 2014


On Wed, Dec 17, 2014 at 02:53:05AM +0300, Dan Carpenter wrote:
> Hello Thierry Reding,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch a52879e8d7cb: "drm/dsi: Add message to packet translator" 
> from Oct 16, 2014, leads to the following Smatch complaint:
> 
> drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet()
> 	 warn: variable dereferenced before check 'msg' (see line 326)
> 
> drivers/gpu/drm/drm_mipi_dsi.c
>    325	{
>    326		const u8 *tx = msg->tx_buf;
>                                ^^^^^^^^^^^
> Dereference.
> 
>    327	
>    328		if (!packet || !msg)
>                                ^^^^
> Check.
> 
>    329			return -EINVAL;
>    330	
> 
> regards,
> dan carpenter

I've had a patch in my tree for almost two weeks now, I wonder why this
is still there...

Ah, forgot to push it of course. Done now.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20141217/2e10b43f/attachment.sig>


More information about the dri-devel mailing list