[PATCH] drm/fb-helper: fix simple_return.cocci warnings

kbuild test robot fengguang.wu at intel.com
Fri Dec 19 03:14:13 PST 2014


drivers/gpu/drm/cirrus/cirrus_fbdev.c:330:1-4: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

CC: Thierry Reding <treding at nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 cirrus_fbdev.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
+++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
@@ -327,11 +327,7 @@ int cirrus_fbdev_init(struct cirrus_devi
 	/* disable all the possible outputs/crtcs before entering KMS mode */
 	drm_helper_disable_unused_functions(cdev->dev);
 
-	ret = drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
-	if (ret)
-		return ret;
-
-	return 0;
+	return drm_fb_helper_initial_config(&gfbdev->helper, bpp_sel);
 }
 
 void cirrus_fbdev_fini(struct cirrus_device *cdev)


More information about the dri-devel mailing list