[PATCH 0/3] drm: Basic mode sanity checks

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Dec 19 08:54:53 PST 2014


On Fri, Dec 19, 2014 at 10:46:02AM -0500, Adam Jackson wrote:
> On Wed, 2014-12-17 at 18:30 +0100, Daniel Vetter wrote:
> 
> > All pulled into my drm misc branch.
> 
> Ugh, wish I'd caught this earlier.  I'm not entirely thrilled with
> requiring non-zero clock, it's not a concept that makes sense on virtual
> hardware.

I'm thinking none of the timing information makes much sense in such
cases. Well, except hdisplay/vdisplay but that's only because our API
sucks a bit and doesn't have the concept of crtc input vs. output size.
hdisplay/vdisplay are used to mean one or the other, depending on the
driver/hardware/output.

That said, I could be convinced to drop the clock check if you think it
can cause problems in the common code.

-- 
Ville Syrjälä
Intel OTC


More information about the dri-devel mailing list