[PATCH] imx-drm: core: handling of DI clock flags to ipu_crtc_mode_set()

Philipp Zabel pza at pengutronix.de
Mon Dec 22 07:28:21 PST 2014


Hi Russell,

On Sun, Dec 21, 2014 at 03:58:19PM +0000, Russell King wrote:
> We do not need to track the state of the IPU DI's clock flags by having
> each display bridge calling back into imx-drm-core, and then back out
> into ipuv3-crtc.c.
> 
> ipuv3-crtc can instead just scan the list of encoders to retrieve their
> type, and build up a picture of which types of encoders are attached.
> We can then use this information to configure the IPU DI clocking mode
> without any uncertainty - if we have multiple bridges connected to the
> same DI, if one of them requires a synchronous DI clock, that's what we
> must use.
> 
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> ---
> This is a clean-up which I've had sitting around for some time, but
> which I think would be useful to get into mainline at some point
> (maybe 3.20?)

Looks good to me, I'll add it to the queue.

thanks
Philipp


More information about the dri-devel mailing list