[PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes

Daniel Vetter daniel at ffwll.ch
Fri Feb 7 07:04:34 PST 2014


On Fri, Feb 07, 2014 at 07:15:05PM +0530, sagar.a.kamble at intel.com wrote:
> From: Sagar Kamble <sagar.a.kamble at intel.com>
> 
> These patches will enable 180 degree rotation for CRTC and Sprite planes.
> Changelog:
> 1. drm/i915: Add 180 degree primary plane rotation support
> Addressed review comments for CRTC rotation from FBC, page flip, CRTC active/
> inactive perspective.
> 2. drm/i915: Calling rotate and inverse rotate transformations after
>     clipping
> Moved drm_rect_rotate below clip operation in intel_update_plane. Added 
> rotate and inverse rotate transforms for dest rect as well.
> 3. drm: Add drm_mode_create_rotation_property()
> Fixed bug in drm_mode_create_rotation_property to create entries only for
> supported rotations.

Clarification wrt cc'ing other mailing lists and driver maintainers:
You've cc'ed the entire patch series to all the lists and maintainers,
which means they'll also get patches they don't care about (like the i915
patches at the end), adding to the overall noise levels.

Best practice is to run the scripts/get_maintainers.pl tool for each
non-i915 patch individually and then add the additional Cc: lines to the
bottom of the commit message like this:

Cc: Rob Clark <robdclark at gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
Cc: "Ville Syrjälä" <ville.syrjala at linux.intel.com>
Cc: dri-devel at lists.freedesktop.org
Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

git send-email will then pick up the additional Cc: entries on each patch.

Cheers, Daniel

> 
> Sagar Kamble (2):
>   drm/i915: Add 180 degree primary plane rotation support
>   drm/i915: Calling rotate and inverse rotate transformations after
>     clipping
> 
> Ville Syrjälä (9):
>   drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h
>   drm: Add support_bits parameter to drm_property_create_bitmask()
>   drm: Add drm_mode_create_rotation_property()
>   drm/omap: Switch omapdrm over to drm_mode_create_rotation_property()
>   drm: Add drm_rect rotation functions
>   drm: Add drm_rotation_simplify()
>   drm/i915: Add 180 degree sprite rotation support
>   drm/i915: Make intel_plane_restore() return an error
>   drm/i915: Add rotation property for sprites
> 
>  drivers/gpu/drm/drm_crtc.c           |  69 ++++++++++++++++-
>  drivers/gpu/drm/drm_rect.c           | 140 +++++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_dma.c      |  12 +++
>  drivers/gpu/drm/i915/i915_drv.h      |   1 +
>  drivers/gpu/drm/i915/i915_reg.h      |   4 +
>  drivers/gpu/drm/i915/intel_display.c |  86 ++++++++++++++++++++-
>  drivers/gpu/drm/i915/intel_drv.h     |   5 +-
>  drivers/gpu/drm/i915/intel_pm.c      |   9 +++
>  drivers/gpu/drm/i915/intel_sprite.c  | 101 +++++++++++++++++++++++--
>  drivers/gpu/drm/omapdrm/omap_drv.h   |   7 --
>  drivers/gpu/drm/omapdrm/omap_plane.c |  17 ++---
>  include/drm/drm_crtc.h               |  15 +++-
>  include/drm/drm_rect.h               |   6 ++
>  13 files changed, 440 insertions(+), 32 deletions(-)
> 
> -- 
> 1.8.5
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list