[PATCHv2 2/4] st/xa: use pipe-loader to get screen

[Rob Clark]

On Tue, Feb 11, 2014 at 7:38 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 11/02/14 12:08, Rob Clark wrote:
>> On Mon, Feb 10, 2014 at 11:36 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 10/02/14 18:34, Rob Clark wrote:
>>>> From: Rob Clark <robclark at freedesktop.org>
>>>>
>>>> This lets multiple gallium drivers use XA.
>>>>
>>> Hi Rob,
>>>
>>> Seems like I should have explained a bit better.
>>>
>>> There is no need to have sourcefiles in order to have a specific target.
>>> All you needed was to link the state-tracker, mesagallium, gallium(aux
>>> library), pipe-loader and a few winsys' to wrap up the library.
>>>
>>> The opencl target + my vdpau/dri patches are a decent example of what I
>>> had in mind.
>>
>> yeah, the only reason for the wrappers in target/xa was to keep
>> -DPIPE_SEARCH_DIR=.. and GALLIUM_PIPE_LOADER_LIBS in targets vs
>> state_trackers.. if you don't care about that, then we can do it with
>> no src files as with opencl.
>>
> In my humble understanding the relationship between state-trackers and
> targets should be one way. Targets should expose the st functionality
> rather than imposing new one back to the st.
> One can build several variations of one st from the by flexing the aux
> module to their liking.

hmm, well this is the case currently with this patch, if I understand
you properly.  A different target could provide it's own loader by
implementing it's own version of xa_pipe_probe(), etc.  I suppose if
someone wanted to, this could be used for static xatracker targets
(ie. libxatracer-vmwgfx.so).  Without any src files in the target, you
could not do this.  But perhaps in this case, where the xa.h lives is
not correct.

It could be that I am missing your point.. ;-)

BR,
-R

> Pardon for the preach
> -Emil
>
>> BR,
>> -R
>>
>>> Sorry for the confusion
>>> -Emil