[patch] drm/vmwgfx: unlock on error path in vmw_execbuf_process()
Thomas Hellstrom
thellstrom at vmware.com
Wed Feb 12 03:24:10 PST 2014
On 02/11/2014 05:03 PM, Dan Carpenter wrote:
> There is a missing unlock on error here.
>
> Fixes: 30f82d816d2d ('drm/vmwgfx: Reemit context bindings when necessary v2')
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 269b85cc875a..9fbbaaa9e541 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -2469,7 +2469,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
> if (dev_priv->has_mob) {
> ret = vmw_rebind_contexts(sw_context);
> if (unlikely(ret != 0))
> - goto out_err;
> + goto out_unlock_binding;
> }
>
> cmd = vmw_fifo_reserve(dev_priv, command_size);
Dan, thanks,
Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>
Queued for next vmwgfx-fixes pull.
/Thomas
More information about the dri-devel
mailing list