[PATCH] drm: Avoid NULL master_priv access in i915 kernel driver

Daniel Vetter daniel at ffwll.ch
Wed Feb 12 14:35:58 PST 2014


On Wed, Feb 12, 2014 at 11:24 PM, Stéphane Marchesin
<marcheu at chromium.org> wrote:
> From: Stuart Abercrombie <sabercrombie at chromium.org>
>
> In several places, including the interrupt handler, the i915 driver assumes
> it can deref. dev->primary->master->driver_priv if dev->primary->master
> is non-NULL.  This wasn't true if drm_open_helper was midway through, so
> rearrange the initialization order.
>
> v2: Address this in drm_open_helper instead of the various access points --
> basically Stephane's fix.
>
> Signed-off-by: Stuart Abercrombie <sabercrombie at chromium.org>
> Signed-off-by: Stéphane Marchesin <marcheu at chromium.org>

Those master_priv derefs in i915 all pre-kms remnants and (for the
stuff in intel_display.c) misguided wip state somehow still left
around. I'll prep patches to kill it all in i915.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list