[PATCH] drm: armada: Use devm_ioremap_resource()

Fabio Estevam festevam at gmail.com
Mon Feb 24 05:56:31 PST 2014


David,

On Mon, Feb 10, 2014 at 7:57 PM, Fabio Estevam <festevam at gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
>
> devm_request_and_ioremap() is deprecated, so use devm_ioremap_resource()
> instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---

Any comments about this one?


>  drivers/gpu/drm/armada/armada_crtc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c
> index d8e3982..2b6e7b7 100644
> --- a/drivers/gpu/drm/armada/armada_crtc.c
> +++ b/drivers/gpu/drm/armada/armada_crtc.c
> @@ -1037,11 +1037,9 @@ int armada_drm_crtc_create(struct drm_device *dev, unsigned num,
>         if (ret)
>                 return ret;
>
> -       base = devm_request_and_ioremap(dev->dev, res);
> -       if (!base) {
> -               DRM_ERROR("failed to ioremap register\n");
> -               return -ENOMEM;
> -       }
> +       base = devm_ioremap_resource(dev->dev, res);
> +       if (IS_ERR(base))
> +               return PTR_ERR(base);
>
>         dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL);
>         if (!dcrtc) {
> --
> 1.8.1.2
>


More information about the dri-devel mailing list