[PATCH 74/85] drivers: gpu: Move prototype declarations to header file radeon.h from evergreen_hdmi.c

Rashika Kheria rashika.kheria at gmail.com
Mon Jan 6 08:38:55 PST 2014


Move prototype declarations of function
dce6_afmt_write_speaker_allocation(), dce6_afmt_write_sad_regs(),
dce6_afmt_select_pin() and dce6_afmt_write_latency_fields() to header
file drm/radeon/radeon.h because they are used by more than one file.

This eliminates the following warnings in drm/radeon/dce6_afmt.c:
drivers/gpu/drm/radeon/dce6_afmt.c:91:6: warning: no previous prototype for ‘dce6_afmt_select_pin’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/dce6_afmt.c:107:6: warning: no previous prototype for ‘dce6_afmt_write_latency_fields’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/dce6_afmt.c:150:6: warning: no previous prototype for ‘dce6_afmt_write_speaker_allocation’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/dce6_afmt.c:196:6: warning: no previous prototype for ‘dce6_afmt_write_sad_regs’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com>
Reviewed-by: Josh Triplett <josh at joshtriplett.org>
---
 drivers/gpu/drm/radeon/evergreen_hdmi.c |    6 ------
 drivers/gpu/drm/radeon/radeon.h         |    5 +++++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm/radeon/evergreen_hdmi.c
index aa695c4..af896ac 100644
--- a/drivers/gpu/drm/radeon/evergreen_hdmi.c
+++ b/drivers/gpu/drm/radeon/evergreen_hdmi.c
@@ -32,12 +32,6 @@
 #include "evergreend.h"
 #include "atom.h"
 
-extern void dce6_afmt_write_speaker_allocation(struct drm_encoder *encoder);
-extern void dce6_afmt_write_sad_regs(struct drm_encoder *encoder);
-extern void dce6_afmt_select_pin(struct drm_encoder *encoder);
-extern void dce6_afmt_write_latency_fields(struct drm_encoder *encoder,
-					   struct drm_display_mode *mode);
-
 /*
  * update the N and CTS parameters for a given pixel clock rate
  */
diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
index 8e0b9dd..b0687fa 100644
--- a/drivers/gpu/drm/radeon/radeon.h
+++ b/drivers/gpu/drm/radeon/radeon.h
@@ -2741,6 +2741,11 @@ int radeon_vm_bo_rmv(struct radeon_device *rdev,
 void r600_audio_update_hdmi(struct work_struct *work);
 struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev);
 struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
+void dce6_afmt_select_pin(struct drm_encoder *encoder);
+void dce6_afmt_write_speaker_allocation(struct drm_encoder *encoder);
+void dce6_afmt_write_sad_regs(struct drm_encoder *encoder);
+void dce6_afmt_write_latency_fields(struct drm_encoder *encoder,
+				    struct drm_display_mode *mode);
 
 /*
  * R600 vram scratch functions
-- 
1.7.9.5



More information about the dri-devel mailing list