[PATCH 66/85] drivers: gpu: Move prototype declarations to header file ni_dpm.h

Rashika Kheria rashika.kheria at gmail.com
Mon Jan 6 08:29:27 PST 2014


Move prototype declarations of functions ni_get_pi() and ni_get_ps() to
header file drm/radeon/ni_dpm.h because it is used by more than one
file.

This eliminates the following warnings in drm/radeon/ni_dpm.c:
drivers/gpu/drm/radeon/ni_dpm.c:723:23: warning: no previous prototype for ‘ni_get_pi’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/ni_dpm.c:730:15: warning: no previous prototype for ‘ni_get_ps’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com>
Reviewed-by: Josh Triplett <josh at joshtriplett.org>
---
 drivers/gpu/drm/radeon/ni_dpm.h |    2 ++
 drivers/gpu/drm/radeon/si_dpm.c |    3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/radeon/ni_dpm.h b/drivers/gpu/drm/radeon/ni_dpm.h
index 6bbee91..876aaf2 100644
--- a/drivers/gpu/drm/radeon/ni_dpm.h
+++ b/drivers/gpu/drm/radeon/ni_dpm.h
@@ -231,6 +231,8 @@ struct ni_power_info {
 #define NISLANDS_DPM2_SQ_RAMP_STI_SIZE                  0x1E
 #define NISLANDS_DPM2_SQ_RAMP_LTI_RATIO                 0xF
 
+struct ni_power_info *ni_get_pi(struct radeon_device *rdev);
+struct ni_ps *ni_get_ps(struct radeon_ps *rps);
 int ni_copy_and_switch_arb_sets(struct radeon_device *rdev,
 				u32 arb_freq_src, u32 arb_freq_dest);
 void ni_update_current_ps(struct radeon_device *rdev,
diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
index 8732005..8ce849e 100644
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -1734,9 +1734,6 @@ static const struct si_powertune_data powertune_data_hainan =
 	true
 };
 
-struct ni_power_info *ni_get_pi(struct radeon_device *rdev);
-struct ni_ps *ni_get_ps(struct radeon_ps *rps);
-
 static int si_populate_voltage_value(struct radeon_device *rdev,
 				     const struct atom_voltage_table *table,
 				     u16 value, SISLANDS_SMC_VOLTAGE_VALUE *voltage);
-- 
1.7.9.5



More information about the dri-devel mailing list