[PATCH v2 17/28] drm/i2c: tda998x: set the repeat PLL value in range 0..3
Jean-Francois Moine
moinejf at free.fr
Mon Jan 13 07:37:35 PST 2014
On Sat, 11 Jan 2014 18:26:02 +0000
Russell King - ARM Linux <linux at arm.linux.org.uk> wrote:
> > div = 148500 / mode->clock;
> > + if (div != 0) {
> > + div--;
> > + if (div > 3)
> > + div = 3;
> > + }
>
> As the driver currently stands, we know that the clock divider works for
> the lower resolution modes. So, as things stand, for 74.25MHz modes,
> we get a divisor of one.
>
> Your patch changes this, the divider becomes zero. I wonder whether
> you've tested 720p modes at all with this?
In 720p, the divider becomes (148500 / 74250 - 1) = 1 and this mode
works fine.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
More information about the dri-devel
mailing list