[PATCH 1/2] drm: provide a helper for the encoder possible_crtcs mask

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 13 04:47:06 PST 2014


On Mon, Jan 13, 2014 at 12:58:54PM +0100, David Herrmann wrote:
> Does that -1 ever make sense? We don't support mode-object-hotplugging
> so all "drm_crtc" objects are known at initialization time. I'd rather
> put a BUG() here than a silent -1. This also makes drm_crtc_mask()
> redundant.

I disagree with that last statement.  drm_crtc_mask() is still useful
for converting to the mask, rather than having that open coded all
over the place.  It probably makes more sense for drm_crtc_mask() to
become a helper in a header file though.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".


More information about the dri-devel mailing list