[PATCH 7/7] drm/gem: dont init "ret" in drm_gem_mmap()
Daniel Vetter
daniel at ffwll.ch
Tue Jan 21 01:51:22 PST 2014
On Mon, Jan 20, 2014 at 08:26:29PM +0100, David Herrmann wrote:
> There is no need to initialize this variable, so drop it. Otherwise, the
> compiler won't warn if we use it unintialized.
>
> Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
I've replied with a few small comments on some patches, with those
addressed all but patch 3 are
Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
A follow-up to 4 to remove callsites from drivers would be neat though.
-Daniel
> ---
> drivers/gpu/drm/drm_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 7bf374e..700e8df 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -819,7 +819,7 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
> struct drm_device *dev = priv->minor->dev;
> struct drm_gem_object *obj;
> struct drm_vma_offset_node *node;
> - int ret = 0;
> + int ret;
>
> if (drm_device_is_unplugged(dev))
> return -ENODEV;
> --
> 1.8.5.3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the dri-devel
mailing list