[PATCH 04/13] drm: turn DRM_MINOR_* into enum

David Herrmann dh.herrmann at gmail.com
Wed Jan 29 06:01:51 PST 2014


Use enum for DRM_MINOR_* constants to avoid hard-coding the IDs.
Furthermore, add a DRM_MINOR_CNT so we can perform range-checks in
follow-ups.

This changes the IDs of the minor-types by -1, but they're not used as
indices so this is fine.

Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
---
 include/drm/drmP.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 89b9d58..c3aaf2d 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1005,9 +1005,12 @@ struct drm_driver {
 	struct list_head legacy_dev_list;
 };
 
-#define DRM_MINOR_LEGACY 1
-#define DRM_MINOR_CONTROL 2
-#define DRM_MINOR_RENDER 3
+enum drm_minor_type {
+	DRM_MINOR_LEGACY,
+	DRM_MINOR_CONTROL,
+	DRM_MINOR_RENDER,
+	DRM_MINOR_CNT,
+};
 
 /**
  * Info file list entry. This structure represents a debugfs or proc file to
-- 
1.8.5.3



More information about the dri-devel mailing list