[PATCH 1/2] drm/radeon: Program page flips to execute in hblank instead of vblank

Michel Dänzer michel at daenzer.net
Tue Jul 1 17:29:22 PDT 2014


On 02.07.2014 01:46, Dieter Nützel wrote:
> Am 01.07.2014 10:14, schrieb Michel Dänzer:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> But move the programming back to the vertical blank interrupt handler.
>> And signal the flip as being completed immediately after programming it
>> to the hardware.
>>
>> This way we don't have to guess whether or not the hardware will execute
>> the flip in a given vertical blank period, avoiding a whole lot of
>> trouble.
>>
>> Also, not using the page flip interrupt anymore avoids problems due to
>> completing page flips earlier than expected by userspace.
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Michel,
> 
> against which tree is this first one?
> Don't apply clean on 3.16-rc2.
> 
> Can't find this in 'my' source (radeon_display.c).
> 
>>>        radeon_crtc->flip_status = RADEON_FLIP_SUBMITTED; <<<
>         spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
>         up_read(&rdev->exclusive_lock);

The patch applies on top of my previous page flipping fix.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer


More information about the dri-devel mailing list