[RFC] drm/msm: DT support for 8960/8064

[Rob Clark]

On Wed, Jul 2, 2014 at 1:12 PM, Olof Johansson <olof at lixom.net> wrote:
> On Wed, Jul 2, 2014 at 7:26 AM, Jordan Crouse <jcrouse at codeaurora.org> wrote:
>> On 07/01/2014 12:57 PM, Rob Clark wrote:
>>>
>>> diff --git a/Documentation/devicetree/bindings/drm/msm/gpu.txt
>>> b/Documentation/devicetree/bindings/drm/msm/gpu.txt
>>> new file mode 100644
>>> index 0000000..6e33efe
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/drm/msm/gpu.txt
>>> @@ -0,0 +1,51 @@
>>> +Qualcomm adreno/snapdragon GPU
>>> +
>>> +Required properties:
>>> +- compatible: "qcom,adreno-3xx"
>>
>>
>> 3xx won't always be the only game in town. Not that I have a better name,
>> just pointing out that it has a limited shelf life.
>
> Actually, we prefer to avoid "xx" compatible strings. The compatible
> should be the first actual device that is part of the xx series, and
> newer IP should claim to be compatible with their own version plus the
> original one (if they are possible to use with the same exact
> programming model and only need extra code to deal with extensions).
>
> That way you'll also have a way to tell them apart in the driver if
> you can't derive it out of register contents, etc.

well, we could put entire chip-id (including the patch revision) in
the compatible string.. ie. qcom,adreno-320.2

BR,
-R

>
> -Olof