[PATCH] drm/exynos: fimd: Keep power enabled during fimd_bind
Tushar Behera
tushar.b at samsung.com
Fri Jul 4 03:33:19 PDT 2014
Under some conditions (when IOMMU is enabled), fimd_bind() accesses
hardware registers and power-domain should be enabled during that time.
fimd_bind --> fimd_mgr_initialize --> fimd_clear_channel
If the power-domain is disabled by that time, we get a boot-time crash.
It would be better to keep power-domain enabled explicitly.
Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0180034
Internal error: : 1008 [#1] PREEMPT SMP ARM
...
PC is at fimd_bind+0x84/0x134
LR is at component_bind_all+0xb4/0x1d8
Signed-off-by: Tushar Behera <tushar.b at samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 33161ad..34275fb 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -888,11 +888,15 @@ static int fimd_bind(struct device *dev, struct device *master, void *data)
struct fimd_context *ctx = fimd_manager.ctx;
struct drm_device *drm_dev = data;
+ pm_runtime_get_sync(dev);
+
fimd_mgr_initialize(&fimd_manager, drm_dev);
exynos_drm_crtc_create(&fimd_manager);
if (ctx->display)
exynos_drm_create_enc_conn(drm_dev, ctx->display);
+ pm_runtime_put_sync(dev);
+
return 0;
}
--
1.7.9.5
More information about the dri-devel
mailing list