drm/vmwgfx: Fix compat shader namespace

Dan Carpenter dan.carpenter at oracle.com
Fri Jul 11 01:43:01 PDT 2014


On Fri, Jul 11, 2014 at 12:14:25AM +0200, Thomas Hellström wrote:
> 
> I agree, however that readability may be more important than the
> fastpath execution speed gained from this. But in my case not so
> much that I spontaneously feel like removing all branch prediction
> hints from the vmwgfx driver.

I'm just saying, let's not add new ones.

> 
> >
> >There are two rules of thumb for likely/unlikely:
> >
> >	1) Don't use it in the drivers/ directory.
> >	2) Or don't use it without benchmarking it.
> 
> Could you point me to a document or some sort of reference?

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-March/025252.html

regards,
dan carpenter



More information about the dri-devel mailing list