[RESEND PATCH V5 01/12] drm/exynos: Move DP setup out of hotplug workqueue

[Sean Paul]

On Wed, Jul 23, 2014 at 11:18 AM, Ajay kumar <ajaynumb at gmail.com> wrote:
> On Wed, Jul 23, 2014 at 8:12 PM, Sean Paul <seanpaul at google.com> wrote:
>> On Wed, Jul 23, 2014 at 7:22 AM, Ajay kumar <ajaynumb at gmail.com> wrote:
>>> Sean,
>>>
>>> On Tue, Jul 22, 2014 at 8:29 PM, Sean Paul <seanpaul at google.com> wrote:
>>>> On Thu, Jul 17, 2014 at 4:43 PM, Ajay Kumar <ajaykumar.rs at samsung.com> wrote:
>>>>> Move the DP training and video enable from the hotplug handler into
>>>>> a seperate function and call the same during dpms ON.
>>>>>
>>>>> With existing code, DP HPD should be generated just few ms before
>>>>> calling enable_irq in dp_poweron.
>>>>>
>>>>> This patch removes that stringent time constraint.
>>>>>
>>>>> Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com>
>>>>
>>>>
>>>> This looks eerily familiar to:
>>>> https://chromium-review.googlesource.com/#/c/65782/
>>>>
>>>> In fact, I think it's probably better to do this in commit, rather than poweron.
>>>>
>>>> Sean
>>> Your are right. This patch contains a subset of changes from the patch
>>> you have mentioned.
>>> But, If I provide commit calback to dp, then it would cause dp to
>>> reinitialize twice
>>> in quick successions - during dpms_on and during commit.
>>> For the user, it would look like a glitch. So, I chose not to provide
>>> a commit callback.
>>>
>>
>> Interesting. At least in my testing, the absence of the commit
>> callback causes my simple test app (which just does drmModeSetCrtc) to
>> fail. In this case, by fail, I mean that the screen just shows black.
>>
>> Sean
> I tried running modetest. It is running fine.
> Also, exynos_drm_encoder_commit calls both dpms_on and
> commit for the encoder. So, there should be no problem I guess!
>
> Your testapp stops working only after adding this patch?


Sorry for taking a while to get back to you, I didn't get the chance
to test this until now.

Yes, my testapp stops working after adding this patch (but works with
the patch which does it in commit).

Sean



>
> Ajay
>
>>>>
>>>>> ---
>>>>>  drivers/gpu/drm/exynos/exynos_dp_core.c |   11 ++++++++++-
>>>>>  1 file changed, 10 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
>>>>> index 845d766..a94b114 100644
>>>>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
>>>>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
>>>>> @@ -875,10 +875,18 @@ static irqreturn_t exynos_dp_irq_handler(int irq, void *arg)
>>>>>  static void exynos_dp_hotplug(struct work_struct *work)
>>>>>  {
>>>>>         struct exynos_dp_device *dp;
>>>>> -       int ret;
>>>>>
>>>>>         dp = container_of(work, struct exynos_dp_device, hotplug_work);
>>>>>
>>>>> +       if (dp->drm_dev)
>>>>> +               drm_helper_hpd_irq_event(dp->drm_dev);
>>>>> +}
>>>>> +
>>>>> +static void exynos_dp_setup(void *in_ctx)
>>>>> +{
>>>>> +       struct exynos_dp_device *dp = in_ctx;
>>>>> +       int ret;
>>>>> +
>>>>>         ret = exynos_dp_detect_hpd(dp);
>>>>>         if (ret) {
>>>>>                 /* Cable has been disconnected, we're done */
>>>>> @@ -1059,6 +1067,7 @@ static void exynos_dp_poweron(struct exynos_dp_device *dp)
>>>>>         exynos_dp_phy_init(dp);
>>>>>         exynos_dp_init_dp(dp);
>>>>>         enable_irq(dp->irq);
>>>>> +       exynos_dp_setup(dp);
>>>>>  }
>>>>>
>>>>>  static void exynos_dp_poweroff(struct exynos_dp_device *dp)
>>>>> --
>>>>> 1.7.9.5
>>>>>