[PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

[Thierry Reding]

On Tue, Jul 29, 2014 at 01:21:48PM +0200, Andreas Färber wrote:
> Hi Ajay,
> 
> Am 28.07.2014 08:13, schrieb Ajay kumar:
> > On 7/27/14, Andreas Färber <afaerber at suse.de> wrote:
> >> Am 25.07.2014 21:22, schrieb Ajay Kumar:
> >>> This series is based on exynos-drm-next branch of Inki Dae's tree at:
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
> >>>
> >>> I have tested this after adding few DT changes for exynos5250-snow,
> >>> exynos5420-peach-pit and exynos5800-peach-pi boards.
> >>
> >> I'm trying to test this with a modified exynos5250-spring DT based off
> >> kgene's for-next branch due to DT, and I run into the following:
> >>
> >>   CC      drivers/gpu/drm/bridge/ptn3460.o
> >> drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_post_encoder_init’:
> >> drivers/gpu/drm/bridge/ptn3460.c:275:2: error: implicit declaration of
> >> function ‘drm_connector_register’ [-Werror=implicit-function-declaration]
> >>   drm_connector_register(&ptn_bridge->connector);
> >>   ^
> > Hope this might help:
> > http://www.spinics.net/lists/dri-devel/msg60578.html
> 
> That fixed my build, thanks.
> 
> Unfortunately the most I got on Spring with attached DT was a blank
> screen with a white horizontal line in the middle.
> 
> Do I need to specify a specific panel model for Spring?
> 
> For testing I re-applied your iommu patches (which btw fail now for 5420
> due to disp_pd) but didn't know what to do about your panel-lvds
> regulator patch now that it's gone.
> 
> If I don't apply this series, then commenting out the dp-controller node
> gets me a working display with simplefb as before.
> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

> From 9172a26a8f0d0f0d170bd27e1c150ad204d8086a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber at suse.de>
> Date: Sun, 27 Jul 2014 21:58:06 +0200
> Subject: [PATCH] ARM: dts: exynos5250: Add eDP/LVDS bridge to Spring
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com>
> [AF: Redone for v6]
> Signed-off-by: Andreas F??rber <afaerber at suse.de>
> ---
>  arch/arm/boot/dts/exynos5250-spring.dts | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
> index 687dfab86bc8..517b1ff2bfdf 100644
> --- a/arch/arm/boot/dts/exynos5250-spring.dts
> +++ b/arch/arm/boot/dts/exynos5250-spring.dts
> @@ -64,10 +64,14 @@
>  		vdd_pll-supply = <&s5m_ldo8_reg>;
>  	};
>  
> +	panel: panel {
> +		compatible = "simple-panel";
> +	};

You can't do this. "simple-panel" isn't a valid panel model. It should
probably be removed from the platform_of_match table in the driver.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140729/363a8db7/attachment.sig>