[PATCH V6 8/8] drm/bridge: Add i2c based driver for ps8622/ps8625 bridge

[Ajay kumar]

Hi Andreas,

On Tue, Jul 29, 2014 at 4:59 PM, Andreas Färber <afaerber at suse.de> wrote:
> Am 25.07.2014 21:22, schrieb Ajay Kumar:
>> From: Vincent Palatin <vpalatin at chromium.org>
>>
>> This patch adds drm_bridge driver for parade DisplayPort
>> to LVDS bridge chip.
>>
>> Signed-off-by: Vincent Palatin <vpalatin at chromium.org>
>> Signed-off-by: Andrew Bresticker <abrestic at chromium.org>
>> Signed-off-by: Sean Paul <seanpaul at chromium.org>
>> Signed-off-by: Rahul Sharma <rahul.sharma at samsung.com>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs at samsung.com>
>> ---
>>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>>  .../devicetree/bindings/video/bridge/ps8622.txt    |   19 +
>>  drivers/gpu/drm/bridge/Kconfig                     |   10 +
>>  drivers/gpu/drm/bridge/Makefile                    |    1 +
>>  drivers/gpu/drm/bridge/ps8622.c                    |  602 ++++++++++++++++++++
>>  5 files changed, 633 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/video/bridge/ps8622.txt
>>  create mode 100644 drivers/gpu/drm/bridge/ps8622.c
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index 46a311e..b4a99cc 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -96,6 +96,7 @@ nxp NXP Semiconductors
>>  onnn ON Semiconductor Corp.
>>  opencores    OpenCores.org
>>  panasonic    Panasonic Corporation
>> +parade       Parade Technologies Inc.
>>  phytec       PHYTEC Messtechnik GmbH
>>  picochip     Picochip Ltd
>>  plathome     Plat'Home Co., Ltd.
>> diff --git a/Documentation/devicetree/bindings/video/bridge/ps8622.txt b/Documentation/devicetree/bindings/video/bridge/ps8622.txt
>> new file mode 100644
>> index 0000000..fdeafb2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/video/bridge/ps8622.txt
>> @@ -0,0 +1,19 @@
>> +ps8622-bridge bindings
>> +
>> +Required properties:
>> +     - compatible: "parade,ps8622" or "parade,ps8625"
>> +     - reg: first i2c address of the bridge
>> +     - sleep-gpios: OF device-tree gpio specification
>> +     - reset-gpios: OF device-tree gpio specification
>> +
>> +Optional properties:
>> +     - lane-count: number of DP lanes to use
>> +
>> +Example:
>> +     ps8622-bridge at 48 {
>
> Nit: Shouldn't this be lvds-bridge like in 7/8 or something else not
> derived from the specific model? Applies to the DT series as well.
Right. I will fix this while sending the next series.

>> +             compatible = "parade,ps8622";
>> +             reg = <0x48>;
>> +             sleep-gpios = <&gpc3 6 1 0 0>;
>> +             reset-gpios = <&gpc3 1 1 0 0>;
>> +             lane-count = <1>
>> +     };
> [...]
>> diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c
>> new file mode 100644
>> index 0000000..ec60fcf
>> --- /dev/null
>> +++ b/drivers/gpu/drm/bridge/ps8622.c
>> @@ -0,0 +1,602 @@
>> +/*
>> + * Parade PS8622 eDP/LVDS bridge driver
>> + *
>> + * Copyright (C) 2014 Google, Inc.
>> + *
>> + * This software is licensed under the terms of the GNU General Public
>> + * License version 2, as published by the Free Software Foundation, and
>> + * may be copied, distributed, and modified under those terms.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
> [...]
>> +MODULE_AUTHOR("Vincent Palatin <vpalatin at chromium.org>");
>> +MODULE_DESCRIPTION("Parade ps8622 eDP-LVDS converter driver");
>> +MODULE_LICENSE("GPL");
>
> "GPL v2"?
Ok. Will change it.

Regards,
Ajay