[PATCH 2/3] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input

Tobias Jakobi tjakobi at math.uni-bielefeld.de
Sun Jun 1 06:42:45 PDT 2014


The hardware accepts scaling factors formatted in a
fixed-point format. The current macro casts to integer
first, then multiplies by the fp conversion factor.

This does not make any sense. In particular, truly
'fractional' inputs, like 1.5, won't work that way.
---
 exynos/fimg2d.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/exynos/fimg2d.h b/exynos/fimg2d.h
index 1aac378..bc45ab5 100644
--- a/exynos/fimg2d.h
+++ b/exynos/fimg2d.h
@@ -25,7 +25,7 @@
 #define G2D_MAX_CMD_LIST_NR	64
 #define G2D_PLANE_MAX_NR	2
 
-#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d) * 65536.0)
+#define G2D_DOUBLE_TO_FIXED(d)		((unsigned int)(d * 65536.0))
 
 enum e_g2d_color_mode {
 	/* COLOR FORMAT */
-- 
1.8.5.5



More information about the dri-devel mailing list