[PATCH qxl.ko] Use surface_id 0 for primary surface on all monitors

Dave Airlie airlied at gmail.com
Tue Jun 3 19:14:34 PDT 2014


I've hand fixed this up and applied it, but please in future submit
patches using the guidelines in Documentation/SubmittingPatches.

Dave.

On 4 June 2014 00:56, David Mansfield <spice at dm.cobite.com> wrote:
> spice-server and downstream code expect that the primary surface
> will always have surface_id = 0, while in reality, once allocated, the
> surface_id in qxl.ko is NEVER 0.  In a dual head environment, all
> monitors render portions of the primary surface.
>
> However, when the monitor config events are generated and sent,
> the primary surface is only mapped to the correct identifier
> (i.e. 0) for the primary head (where crtc index is 0).
>
> The fix is to look at the "primary" flag in the bo and always
> use id 0, irrespective of which head is being configured.
>

I've hand fixed this up and applied it, but please in future submit
patches using the guidelines in Documentation/SubmittingPatches.

Dave.


More information about the dri-devel mailing list