[PATCH 4/5] drm/omap: use __GFP_DMA32 for shmem-backed gem

Rob Clark robdclark at gmail.com
Thu Jun 5 07:04:08 PDT 2014


On Thu, Jun 5, 2014 at 9:52 AM, Tomi Valkeinen <tomi.valkeinen at ti.com> wrote:
> Hi,
>
> On 02/06/14 16:03, David Herrmann wrote:
>> Hi Tomi
>>
>> Any chance you could give this a spin on an omap device? It shouldn't
>> affect any 32bit devices, so this is mostly a cosmetic change.
>> However, I'd really like to get rid of that 'TODO' item. So a
>> "Tested-by:" would be really nice.
>
> I made a quick test on omap4. I verified that the changed code is ran,
> and I can get a picture on my monitor with omapdrm.
>
> So tested by me, but I'm not familiar with shmem so I can't really say
> anything about the change itself without studying this further.

Thanks for testing it.  The change looks ok, I just had a nagging
doubt about it because I had problems w/ GFP32 before (but was
probably just missing mapping_set_gfp_mask()), so was hoping that
someone could confirm that it actually did work as intended.

Anyways, with that:

Reviewed-by: Rob Clark <robdclark at gmail.com>


BR,
-R


More information about the dri-devel mailing list